Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modulemap for system sqlite #1

Merged
merged 2 commits into from
Apr 10, 2017
Merged

Modulemap for system sqlite #1

merged 2 commits into from
Apr 10, 2017

Conversation

zmeyc
Copy link
Contributor

@zmeyc zmeyc commented Apr 8, 2017

No description provided.

@zmeyc zmeyc mentioned this pull request Apr 8, 2017
Package.swift Outdated
import PackageDescription

let package = Package(
name: "SQLiteSDK",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package.swift Outdated
let package = Package(
name: "SQLiteSDK",
providers: [
.Apt("libsqlite3-dev")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of sheer curiosity: which version of SQLite is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually needed only on Linux (for apt-get). It prints a hint if sqlite is not installed.
3.8.2 on Ubuntu 14.04
3.11.0 on 16.04
I don't know which version is preinstalled on OS X.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I understand - I guess that the -dev suffix just means that it comes with sqlite3.h.

The question of the version that comes preinstalled on macOS/iOS is important in GRDB, because some features are protected with @available attributes. But I'm sure SPM supports them correctly.

For Linux, we'll need to talk about the SQLite version with more details. But we're not there yet :-)

@groue
Copy link
Owner

groue commented Apr 10, 2017

I think it's ready now, isn't it, @zmeyc ?

@zmeyc
Copy link
Contributor Author

zmeyc commented Apr 10, 2017

@groue Yes, I've updated the PR.

@groue groue merged commit 41d2481 into groue:master Apr 10, 2017
@groue
Copy link
Owner

groue commented Apr 10, 2017

💯 @zmeyc, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants